[OE-core] [PATCH 5/5] package.bbclass: fixup_perms - symlink bug fix

[Mark Hatle]

On 7/25/11 9:05 AM, Phil Blundell wrote:
> On Mon, 2011-07-25 at 14:47 +0100, Richard Purdie wrote:
>> From: Mark Hatle <mark.hatle at windriver.com>
>>
>> We don't want to change the owner/mode of symlinks, as this may
>> affect the target of the link.  Also broken links will fail as well.
> 
> This seems like it will cause links themselves to end up getting shipped
> under the UID/GID that was used for building, which was the whole thing
> that fixup_perms was trying to avoid in the first place.  Surely you do
> want to fix their ownership, it's just the mode that you oughtn't to be
> trying to change.

symlinks do not have an ownership/group on most filesystems.  They automatically
inherit the uid/gid of the target.  (I also believe this is the same for
permissions.)

How do you change the mode of the link itself?  As far as I understood this
can't be done on most filesystems.  I'd be happy to attempt to change the
owner/group (and mode) of symlinks if there is a way not to follow the link.

> Also, unrelated to the technical details, the subject line of this patch
> is not especially illuminating.  It would be better to say something
> like "package.bbclass: don't change mode/owner of symlinks" rather than
> like "symlink bug fix".

This was discovered when I had a package that contained broken symlinks.  The
fixup_perms broke on me.  Thus the short description... [it can certainly be
changed]

--Mark

> p.
> 
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core