[OE-core] [PATCH] bb-matrix.sh: check for the existence of time
Jeff Mitchell
jmitchell at ll.mit.edu
Tue Jul 26 22:50:20 UTC 2011
On 07/26/2011 06:41 PM, Darren Hart wrote:
>
> Hi Jeff,
>
> Thanks for the patch. A couple points of feedback below:
>
> On 07/26/2011 02:57 PM, Jeff Mitchell wrote:
>> What an existential subject. The patch is quite self-explanatory.
>
> Well, there is almost always a need for commit log beyond just the
> subject. The only exception might be "whitespace fixes only" or
> "spelling fixes only".
I did write a commit log, but git-format-patch turned it into the
subject of the attached patch. No, I haven't used git-format-patch
before :-) (I've been fortunate to have been able to avoid it for many
years now.)
> Also, while it is tempting to squeeze in typo fixes and such with a
> functional patch, unless they are in the code you are changing anyway,
> they should be sent as separate patches.
Given the triviality of both changes I didn't think this would be an issue.
--Jeff
More information about the Openembedded-core
mailing list