[OE-core] [PATCH] [PATCH] raptor: add recipe

Koen Kooi koen at dominion.thruhere.net
Thu Jul 28 10:48:00 UTC 2011


Op 28 jul. 2011, om 05:38 heeft Ben Gardiner het volgende geschreven:

> Signed-off-by: Frans Meulenbroeks <fransmeulenbroeks at gmail.com>
> Signed-off-by: Ben Gardiner <bengardiner at nanometrics.ca>
> Signed-off-by: Tom Rini <tom_rini at mentor.com>
> 
> This recipe is a port of recipes/raptor/raptor_1.4.21.bb from
> git://git.openembedded.org/openembedded, commits
> 01e8e9f325d8d251e852e7a5704b5fe50880e1ad 'raptor: added recipe' and
> f1d24b5a986233f869364eb109476f5184e76d10 'raptor: add libxml2 DEPENDS'

Why does this need to be in OE-core and not in some other layer? It doesn't look so core to me, especially since nothing in oe-core (or meta-oe/efl/gnome for that matter) depends on it

> 
> The recipe was modified by adding a LIC_FILES_CHKSUM assignment.
> 
> Signed-off-by: Ben Gardiner <bengardiner at nanometrics.ca>
> 
> ---
> 
> Not tested in the oe-core + meta-openembedded et. al. layers.

So why are you sending it if it isn't tested?

> We are not
> ready yet to migrate from the 2011.03-maintenance branch. This patch is
> proposed for inclusion in oe-core so that we can meet the new policy
> requirements for inclusion in the 2011.03-maintenance branch

Where does it say it's OK to do a pull request for untested recipes? And where does it say it needs to be in OE-core first?

> and submit
> a subsequent pull-request for commit

I seriously disagree with sending pull requests for the maintenaince branch for untested recipes!



More information about the Openembedded-core mailing list