[OE-core] [PATCH 2/4] gcc: Drop part of the 64bithack patch which is no longer used

Kumar Gala galak at kernel.crashing.org
Thu Jul 28 14:55:48 UTC 2011


On Jul 28, 2011, at 9:35 AM, Lu, Lianhao wrote:

> Richard Purdie wrote on 2011-07-27:
>> Since we now handle GLIBC_DYNAMIC_LINKER in gcc-configure-common.inc:
>> 
>> 's#\(GLIBC_DYNAMIC_LINKER[^ ]*\)\( *"/lib.*\)#\1 SYSTEMLIBS_DIR\2#'
>> 
> 
> It seems to me that this patch may not be removed. The above code in gcc-configure-common.inc said it only useful for SDK. For gcc-cross, it doesn't change /lib64/ld-linux-x86-64.so.2 to /lib/ld-linux-x86-64.so.2 as what the 64bithack.patch does.
> 
> -Lianhao

Agreed, seeing similar issues on ppc64.  I think the sed line might not be doing with Richard intended.

We get:

./i386/linux.h:#define GLIBC_DYNAMIC_LINKER SYSTEMLIBS_DIR "/lib/ld-linux.so.2"
./i386/linux64.h:#define GLIBC_DYNAMIC_LINKER32 SYSTEMLIBS_DIR "/lib/ld-linux.so.2"
./i386/linux64.h:#define GLIBC_DYNAMIC_LINKER64 SYSTEMLIBS_DIR "/lib64/ld-linux-x86-64.so.2"

- k


> 
>> we can drop the patch which changes a hardcoded value for this.
>> 
>> No PR bump since there is no code change resulting from this, its just
>> a cleanup.
>> 
>> There is still a valid question over the remainder of this patch and
>> its interaction with multilib configurations.
>> 
>> Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
>> ---
>> .../recipes-devtools/gcc/gcc-4.5.1/64bithack.patch |   13 -------------
>> meta/recipes-devtools/gcc/gcc-4.6/64bithack.patch  |   13 -------------
>> 2 files changed, 0 insertions(+), 26 deletions(-)
> 
> 
> 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core





More information about the Openembedded-core mailing list