[OE-core] [PATCH 2/2] eglibc: migrate configurability from oe

[Khem Raj]

On Tue, Jun 7, 2011 at 6:59 PM, Kang Kai <Kai.Kang at windriver.com> wrote:
> On 2011年06月07日 17:53, Phil Blundell wrote:
>>
>> On Tue, 2011-06-07 at 17:42 +0800, Kang Kai wrote:
>
> Hi Phil,
>
> Thanks for your comment.
>>>
>>> -DISTRO_FEATURES ?= "alsa bluetooth ext2 irda pcmcia usbgadget usbhost
>>> wifi nfs zeroconf pci"
>>> +DISTRO_FEATURES ?= "alsa bluetooth ext2 irda pcmcia usbgadget usbhost
>>> wifi nfs zeroconf pci \
>>> +               libc-ipv6 libc-backtrace libc-big-macros libc-bsd
>>> libc-cxx-tests libc-catgets libc-charsets libc-crypt \
>>
>> I don't think it is a good idea to invent a new "libc-ipv6" feature; you
>> can just use the existing "ipv6" one.  This is probably true for some of
>> your others too.
>
> eglibc needs to support ipv6 by default, but if other application such as
> iptables doesn't want to support ipv6, remove "ipv6" will also disable
> eglibc ipv6 support。

I think if one distro does not need ipv6 then having it in eglibc is not needed
too

> If it is ok to disable or enable ipv6 at same time, I will update the patch
> with "ipv6".
>
>>> +        # try to fix disable charsets/locales/locale-code compile fail
>>> +        if 'libc-charsets' in distro_features and 'libc-locales' in
>>> distro_features and 'libc-locale-code' in distro_features:
>>> +            bb.data.setVar('PACKAGE_NO_GCONV', '0', d)
>>> +        else:
>>> +            bb.data.setVar('PACKAGE_NO_GCONV', '1', d)
>>
>> Does that actually work?
>
> Yes, it works. I can build eglic after uncomment the line in
> local.extended.conf to disable all configurable options. But remove the
> codes above, it will fail.
>>
>> p.
>>
>>
> Regards,
> Kai
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core at lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>