[OE-core] [RFC PATCH 2/2] sanity: implement network connectivity test
Joshua Lock
josh at linux.intel.com
Mon Jun 20 16:20:59 UTC 2011
On Sun, 2011-06-19 at 08:03 -0700, Jeremy Puhlman wrote:
> > + test_uris= ["http://yoctoproject.org/about",
> > + "https://eula-downloads.yoctoproject.org/crownbay/crownbay-bernard-5.0.0",
> > + "git://git.yoctoproject.org/yocto-firewall-test;protocol=git;rev=HEAD"]
> > + retval = ""
>
> These should probably be set as setable from the meta data. It is a
> reasonable default, but hard coding it with out a way to change it is
> probably not what we want.
Agreed.
>
> > +
> > + # Only check connectivity if network and this check enabled
> > + # Because it's a fairy heavy test allow disabling of just this sanity test
> > + # by setting DISABLE_NETWORK_SANITY
> > + data = bb.data.createCopy(d)
> > + network_disabled = not bb.data.getVar('BB_NO_NETWORK', data, True)
> > + check_disabled = bb.data.getVar('DISABLE_NETWORK_SANITY', data, True)
> > + if check_disabled or network_disabled:
>
> Completely minor gnit. The copy here isn't needed until you start
> setting the DL_DIR. Why not wait til after the check to see if we need
> to do it.
Good catch!
>
> Otherwise seem like a solid idea.
>
Thanks for the review Jeremy, v2 on it's way later today.
Cheers,
Joshua
--
Joshua Lock
Yocto Project Build Monkey
Intel Open Source Technology Centre
More information about the Openembedded-core
mailing list