[OE-core] [PATCH 1/1] base.bbclass: show layer's branches/revisions in the banner info

Cui, Dexuan dexuan.cui at intel.com
Tue Jun 28 14:52:03 UTC 2011


Mark Hatle wrote:
> On 6/28/11 1:45 AM, Koen Kooi wrote:
>> 
>> Op 28 jun 2011, om 07:37 heeft Dexuan Cui het volgende geschreven:
>> 
>> .......
>> So it works as expected, but the output is a bit confusing. I have a
>> few (conflicting) suggestions: 
>> 
>> 1) replace _BRANCH and _REVISION with ' branch' and ' revision',
>> e.g.: 
>> 
>> 	meta-archos branch          = "master"
>> 	meta-archos revision        =
>> "413933fb5f62574e38a9a1e38905ba6e9c1be4ad" 
>> 
>> 2) for the extra layers put branch and revision on a single line:
>> 
>> 	meta-archos          =
>> "master/413933fb5f62574e38a9a1e38905ba6e9c1be4ad" 
>> 
>> 3) Move the revision info down, e..g
>> 
>> OE Build Configuration:
>> BB_VERSION                  = "1.13.1"
>> TARGET_ARCH                 = "arm"
>> TARGET_OS                   = "linux-gnueabi"
>> MACHINE                     = "beagleboard"
>> DISTRO                      = "angstrom"
>> DISTRO_VERSION              = "v2011.06-core"
>> TARGET_FPU                  = "hard"
>> METADATA_BRANCH             = "master"
>> METADATA_REVISION           =
>> "364ca0d2d0399c8cc6d3b3fc28308e1e14673544" 
>> meta-angstrom_BRANCH        = "master"
>> meta-angstrom_REVISION      =
>> "c19c342c62416752117c2dce4696840bc864f647" 
>> 
>> etc.
>> 
>> What do you think about that?
> 
> I think my preference is either 3 or a combination of 2 & 3.
> 
> To me the important bits are the configuration settings, followed by
> the components that are being used as a secondary concern.  It will
> all help in debugging and issue, but if the target/distro isn't
> correct then it doesn't matter what the rest is.
> 
> --Mark
> 

Hi, thank you very much for the suggestions!
I worked out a vesion 2 patch that combines 2 and 3:
http://git.pokylinux.org/cgit/cgit.cgi/poky-contrib/commit/?h=dcui/banner_v2&id=2c2d9d7c0e942b6748bc8bd7d5980113bae9a836

Please note I use a colon mark rather than a slash mark for better readabability since a branch name can contain colon.

An output result in my side is:
OE Build Configuration:
BB_VERSION                  = "1.13.1"
TARGET_ARCH                 = "i586"
TARGET_OS                   = "linux"
MACHINE                     = "qemux86"
DISTRO                      = "poky"
DISTRO_VERSION              = "1.0+snapshot-20110628"
TARGET_FPU                  = ""
METADATA_BRANCH             = "dcui/banner_v2"
METADATA_REVISION           = "2c2d9d7c0e942b6748bc8bd7d5980113bae9a836"
meta-sugarbay               = "dcui/test1:76d1178ba1a43cf6457c89717134aeb9f1275fae"

Please let me know if this new output looks ok.

BTW,  Koen, even with this v2 patch, the list looks still pretty long in your side.
I noticed there are some layers with the same revision: e.g., 
meta-htc_REVISION           = "f37d05ca7450f85642cea0e43a75df10663bd8f6"
meta-nokia_BRANCH           = "master"
meta-nokia_REVISION         = "f37d05ca7450f85642cea0e43a75df10663bd8f6"
meta-openmoko_BRANCH        = "master"
meta-openmoko_REVISION      = "f37d05ca7450f85642cea0e43a75df10663bd8f6"
meta-palm_BRANCH            = "master"
meta-palm_REVISION          = "f37d05ca7450f85642cea0e43a75df10663bd8f6"
meta-zaurus_BRANCH          = "master"
meta-zaurus_REVISION        = "f37d05ca7450f85642cea0e43a75df10663bd8f6"

I guess they actually belong to the same repo.
In this case, maybe we can further improve the output format to:
meta-htc,nokia,openmoko,palm,zaurus:f37d05ca7450f85642cea0e43a75df10663bd8f6 ?

Thanks,
-- Dexuan



More information about the Openembedded-core mailing list