[OE-core] [RFC v3 PATCH 0/9] Linux 3.0 build support

Anders Darander anders at chargestorm.se
Thu Jun 30 09:20:07 UTC 2011


On Thu, Jun 30, 2011 at 10:00, Richard Purdie
<richard.purdie at linuxfoundation.org> wrote:
> On Wed, 2011-06-29 at 20:02 +0200, Anders Darander wrote:
>> On Wed, Jun 29, 2011 at 19:54, Anders Darander <anders at chargestorm.se> wrote:
>> >
>> > v3: - task-base.bb: fix a problem that *pcmia26 couldn't be found.

>> Unless I find some more problems, or get such reports, I plan to send
>> a pull request towards the end of this week.
>
> It looks good to me apart from some ordering and PR bump type issues.
>
> Where you change the depmod dependency for example, we really need to
> rebuild module-init-tools at the same time so the binary changes name at
> the right point in the series. Patch 4 and patch 2 therefore probably
> need to be together with a PR bump.

You're right, of course there should have been a PR bump there. I'll fix it and
squash patch 4 into patch 2 before I'll send a pull request.

>  I also wondered what the patch to
> module-init-tools you're removing does (and why you just disabled rather
> than deleted it).

I left it in there of laziness, in case someone had objected to the disabling
of the patch. As I'm not really sure of the purpose of that patch, I'll delete
the patch before I send the pull request. Then we'll probably find out
if someone
had any need for that patch...

> Looks good though! I'm trying to resist merging some of the standalone
> bits straight away :)

Thanks!
If you get too eager to cherrypick a few bits, it's no problem.
Otherwise you can
count on getting a pull request tomorrow.

Cheers,
Anders




More information about the Openembedded-core mailing list