[OE-core] [PATCH 6/6] sanity.bbclass: Check for mmap_min_addr can be safely removed

Mark Hatle mark.hatle at windriver.com
Wed Mar 2 01:47:13 UTC 2011


If we set the value to 65536 in the other patch, I'd prefer this check remain
and check for 65536 instead.  (Or change the check to show that it has a high
probability of working.)

--Mark

On 3/1/11 7:38 PM, Khem Raj wrote:
> * QEMU is already patch to take care of it
> 
> Signed-off-by: Khem Raj <raj.khem at gmail.com>
> ---
>  meta/classes/sanity.bbclass |   11 -----------
>  1 files changed, 0 insertions(+), 11 deletions(-)
> 
> diff --git a/meta/classes/sanity.bbclass b/meta/classes/sanity.bbclass
> index 13940f8..2af6f4b 100644
> --- a/meta/classes/sanity.bbclass
> +++ b/meta/classes/sanity.bbclass
> @@ -166,17 +166,6 @@ def check_sanity(e):
>      if "." in data.getVar('PATH', e.data, True).split(":"):
>          messages = messages + "PATH contains '.' which will break the build, please remove this"
>  
> -    if data.getVar('TARGET_ARCH', e.data, True) == "arm":
> -        # This path is no longer user-readable in modern (very recent) Linux
> -        try:
> -            if os.path.exists("/proc/sys/vm/mmap_min_addr"):
> -                f = file("/proc/sys/vm/mmap_min_addr", "r")
> -                if (f.read().strip() != "0"):
> -                        messages = messages + "/proc/sys/vm/mmap_min_addr is not 0. This will cause problems with qemu so please fix the value (as root).\n\nTo fix this in later reboots, set vm.mmap_min_addr = 0 in /etc/sysctl.conf.\n"
> -                f.close()
> -        except:
> -            pass
> -
>      for util in required_utilities.split():
>          if not check_app_exists( util, e.data ):
>              missing = missing + "%s," % util





More information about the Openembedded-core mailing list