[OE-core] [PATCH V2 1/1] scripts/poky-qemu-internal: Add call to stty

Richard Purdie richard.purdie at linuxfoundation.org
Fri Mar 25 13:34:29 UTC 2011


On Wed, 2011-03-23 at 11:13 -0700, Khem Raj wrote:
> On Wed, Mar 23, 2011 at 9:53 AM, Richard Purdie
> <richard.purdie at linuxfoundation.org> wrote:
> > On Mon, 2011-03-21 at 11:34 -0700, Khem Raj wrote:
> >> When qemu is booted into console with -nographics
> >> then after exiting the terminal line settings are messed
> >> up. This patch calls stty sane to restore the terminal
> >> settings to default.
> >>
> >> stty is part of coreutils which is installed on all
> >> host distros hence there is no need to warn about it
> >> being available or not
> >>
> >> Signed-off-by: Khem Raj <raj.khem at gmail.com>
> >> ---
> >>  scripts/poky-qemu-internal |    1 +
> >>  1 files changed, 1 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/scripts/poky-qemu-internal b/scripts/poky-qemu-internal
> >> index 8fd1834..556ce69 100755
> >> --- a/scripts/poky-qemu-internal
> >> +++ b/scripts/poky-qemu-internal
> >> @@ -189,6 +189,7 @@ cleanup() {
> >>          echo "poky-export-rootfs stop $ROOTFS"
> >>          poky-export-rootfs stop $ROOTFS
> >>      fi
> >> +    stty sane
> >>  }
> >>
> >>  n1=$[ (`echo $TAP | sed 's/tap//'` * 2) + 1 ]
> >
> > With the recent change to the script to run:
> >
> > $QEMUBIN -kernel $KERNEL $QEMUOPTIONS $SERIALOPTS -no-reboot $SCRIPT_QEMU_OPT $SCRIPT_QEMU_EXTRA_OPT --append "$KERNCMDLINE $SCRIPT_KERNEL_OPT" || stty sane
> >
> > is the above change still needed?
> 
> this will only execute if the command fails I guess. But the problem
> happens even if qemu ran well.

Ok, I'll take your version but can you update it to remove this other
stty call please? :)

Cheers,

Richard





More information about the Openembedded-core mailing list