[OE-core] [PATCH] create-pull-request: Add -l location switch

[Martin Jansa]

On Tue, May 10, 2011 at 04:01:06PM -0700, Tom Rini wrote:
> On 05/10/2011 12:18 PM, Otavio Salvador wrote:
> > On Tue, May 10, 2011 at 15:55, Tom Rini <tom_rini at mentor.com> wrote:
> >> Add a -l switch that takes an argument of either github or gitorious
> >> and will make the cover letter have a fill-in-the-blank of where the
> >> changes are on either github or gitorious.
> > 
> > Another possibility would be to use git config interface to store
> > those. You might have something like:
> > 
> > [oe-core-pull-request]
> > mode = github
> > user = foo
> > 
> > or
> > 
> > [oe-core-pull-request]
> > mode = gitorious
> > user = bar
> > 
> > This could be used to fill the fields in a proper way since those are
> > predictable.
> 
> If I had a good bit more time, I might re-write the script in python and
> parse .ini files (same syntax as gitconfig) so that lots of useful
> defaults could be saved.  But here's the real test, given that you're an
> intended user, would you use the -l switch or just make a local change
> to the script like Martin showed?

I would still use local copy of script just because in this case it has
selective name and I can find it already with right params in bash history.
To have the same comfort with -l switch you would have to provide bash
completition config :).

And yes -l switch is good thing, I can replace my copies with simple
alias now..

Regards,
-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com