[OE-core] RFC: create-pull-request / send-pull-request updates
Otavio Salvador
otavio at ossystems.com.br
Thu May 12 00:49:55 UTC 2011
On Wed, May 11, 2011 at 13:15, Darren Hart <dvhart at linux.intel.com> wrote:
> 2) create-pull-request needs to facilitate the use of multiple
> repositories (Tom Rini)
>
> Some folks find gitorious or github work best for their use. It is
> also reasonable to want to use this script with independent layers.
> Tom proposed a -l option to specify the PULL_URL leaving some
> boiler-plate text in the cover-letter for the user to populate.
>
> This dovetails with something I've been considering. Rather than
> duplicate the generation of a pull request cover letter, I'd like to
> see us re-use the output of 'git request-pull'. This has the added
> benefit of sanity checking the URL and commits. It does however
> remove the concept of the BROWSE_URL. We could add the BROWSE_URL
> back for recognized locations (git.yoctoproject.org, gitorious, and
> github I believe).
>
> Some have expressed a desire for the URL to be automatically
> discoverable. We could try and extract this information from the
> current branch and a remote of a specific name, with some URL
> rewrites to convert ssh access to generic git access. Unfortunately,
> this approach breaks under several conditions. I would prefer that
> these scripts not be tied to any particular naming conventions for
> the git branches or remotes.
>
> I propose we go with something very similar to Tom's -l PULL_URL
> proposal and replace the cover letter generation with the output of
> 'git request-pull'. The PULL_URL should also be able to be specified
> via an environment variable. Now that we are sending patches for
> review and not just the pull request itself, I feel we can drop the
> BROWSE_URL.
I'd prefer to have it stored into git config backend and don't need to
retype it for every call.
--
Otavio Salvador O.S. Systems
E-mail: otavio at ossystems.com.br http://www.ossystems.com.br
Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br
More information about the Openembedded-core
mailing list