[OE-core] [RFC PATCH 08/10] send-pull-request: fix greedy auto-cc regex

Bruce Ashfield bruce.ashfield at gmail.com
Sat May 14 05:41:23 UTC 2011


On Fri, May 13, 2011 at 7:38 PM, Darren Hart <dvhart at linux.intel.com> wrote:
> A greedy regular expression caused emails to be harvested from patches
> that were quoted in the commit message. Ensure only tags that start at the
> beginning of the line are considered for harvesting.
>
> NOTE: users are still responsible for verifying the recipients list and to
>      ensure they do not spam people!

This is key!

But a change for the better.

Acked-by: Bruce Ashfield <bruce.ashfield at windriver.com>

Bruce

>
> Signed-off-by: Darren Hart <dvhart at linux.intel.com>
> Cc: Richard Purdie <richard.purdie at linuxfoundation.org>
> Cc: Saul Wold <sgw at linux.intel.com>
> Cc: Bruce Ashfield <bruce.ashfield at windriver.com>
> ---
>  scripts/send-pull-request |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/scripts/send-pull-request b/scripts/send-pull-request
> index d265c47..b294d35 100755
> --- a/scripts/send-pull-request
> +++ b/scripts/send-pull-request
> @@ -90,7 +90,7 @@ done
>  if [ $AUTO -eq 1 ]; then
>        harvest_recipients TO "^[Tt][Oo]: *"
>        harvest_recipients CC "^[Cc][Cc]: *"
> -       harvest_recipients CC "^.*-[Bb][Yy]: *"
> +       harvest_recipients CC "^[A-Z][A-Za-z-]*-[Bb][Yy]: *"
>  fi
>
>  AUTO_TO="$(git config sendemail.to)"
> --
> 1.7.1
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>



-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"




More information about the Openembedded-core mailing list