[OE-core] [PATCH 2/2] opkg-utils: Allow uppercase lettlers in package names

Richard Purdie richard.purdie at linuxfoundation.org
Fri May 20 16:31:22 UTC 2011


On Fri, 2011-05-20 at 18:05 +0200, Andreas Oberritter wrote:
> On 05/20/2011 05:01 PM, Phil Blundell wrote:
> > On Fri, 2011-05-20 at 07:45 +0100, Phil Blundell wrote:
> >> On Thu, 2011-05-19 at 14:09 -0700, Khem Raj wrote:
> >>> Some packages have uppercase letters in their names e.g.
> >>> efikamx kernel. We allow uppercase character with
> >>> uppercase-letters.patch
> >>
> >> This is not a good idea.  Uppercase characters have never been permitted
> >> in .deb/.ipk. 
> >>
> >> Isn't legitimize_package_name() crunching them to lower case for you?
> >> If not then I think it should be made to do that.
> > 
> > I just checked the code and it certainly looks like it should be doing
> > that:
> > 
> > 	# Remaining package name validity fixes
> > 	return s.lower().replace('_', '-').replace('@', '+').replace(',', '+').replace('/', '-')
> > 
> > So if that isn't working for you then I think it needs a bit of
> > debugging.
> 
> http://patches.openembedded.org/patch/2255/ should solve the problem. I
> was waiting for a second ack.
> 
> Khem, if this fixes the problem for you, please send an ack or push this
> patch.

I merged this to OE-Core since I happened to look at it :)

Cheers,

Richard





More information about the Openembedded-core mailing list