[OE-core] [PATCH 2/2] distcc_2.18.3.bb: Fix compilation on uclibc

[Koen Kooi]

Op 21 mei 2011, om 09:19 heeft Khem Raj het volgende geschreven:

> 
> 
> -Khem
> 
> On May 20, 2011, at 11:34 PM, Phil Blundell <pb at pbcl.net> wrote:
> 
>> On Fri, 2011-05-20 at 16:19 -0700, Khem Raj wrote:
>>> -DEPENDS = "avahi gtk+"
>>> +DEPENDS = "avahi ${GTKDEP}"
>>> +GTKDEP-libc-uclibc = ""
>>> +GTKDEP = "gtk+"
>> 
>> Does that really work?  Surely it should be "GTKDEP_libc-uclibc".
>> 
> 
> No it does not RP pointed it out earlier and I have since fixed it
> 
>>> -EXTRA_OECONF = " --with-gtk "
>>> -
>>> +EXTRA_OECONF_libc-glibc = " --with-gtk "
>>> +EXTRA_OECONF_libc-uclibc = " --without-gtk --without-gnome "
>> 
>> Can you make this use the same logic as above?
>> 
> 
> Is there a problem with this logic ?
> 
>>> +DESKTOPINSTALL = ""
>>> +DESKTOPINSTALL_libc-glibc () {
>>> +    install -d ${D}${datadir}/distcc/
>>>   install -m 0644 ${WORKDIR}/distccmon-gnome.desktop ${D}${datadir}/distcc/
>>> }
>> 
>> Likewise, or find some way to eliminate it entirely.
>> 
>>> -
>>> -PACKAGES += "distcc-distmon-gnome"
>>> +PACKAGES_append_libc-glibc = " distcc-distmon-gnome"
>> 
>> Is that needed?
>> 
> 
> May be not it will just be empty in uclibc case

since ALLOW_EMPTY is not set, this change is unneeded.