[OE-core] [PATCH 2/9] update-alternatives-dpkg: Update to dpkg base 1.15.8.7

[Phil Blundell]

On Sun, 2011-05-22 at 11:48 -0700, Saul Wold wrote:
> --- a/meta/recipes-devtools/update-alternatives/update-alternatives-dpkg.inc
> +++ b/meta/recipes-devtools/update-alternatives/update-alternatives-dpkg.inc
> @@ -5,10 +5,12 @@ programs fulfilling the same or similar functions and how they can be installed
>  time."
>  LICENSE = "GPL"
>  SECTION = "base"
> -SRC_URI = "${DEBIAN_MIRROR}/main/d/dpkg/dpkg_${PV}.tar.gz"
> +SRC_URI = "${DEBIAN_MIRROR}/main/d/dpkg/dpkg_${PV}.tar.bz2"
>  S = "${WORKDIR}/dpkg-${PV}"
>  PACKAGE_ARCH = "all"
> -PR = "r2"
> +PR = "r0"

Why is this in the .inc file at all?  It seems a bit bogus to have a PR
value defined here that needs to be rewound whenever PV is changed
somewhere else.

> +PROVIDES += "virtual/update-alternatives"
> +RPROVIDES_${PN} += "update-alternatives"
> +EXTRA_RDEPENDS = "perl dpkg"
> +EXTRA_RDEPENDS_virtclass-native = ""
> +RDEPENDS_${PN} += "${EXTRA_RDEPENDS}"

Conversely, why is this stuff in the .bb file rather than in the .inc?
Presumably all the lines above are version invariant.

Also (although this isn't really a comment on your patch), why does
u-a-dpkg RDEPEND on dpkg in the first place?  That seems like it rather
defeats the whole point of having this as a separate recipe.

p.