[OE-core] [CONSOLIDATED PULL 06/28] qmmp: update to 0.5.2

[Koen Kooi]

Op 5 nov. 2011, om 18:22 heeft Saul Wold het volgende geschreven:

> From: Xiaofeng Yan <xiaofeng.yan at windriver.com>
> 
> Remove recipe qmmp_0.5.1 and add qmmp_0.5.2

That isn't formatted according to the commit policy

> 
> Use do_split_package for each grouping and name them correctly besides updating package.
> The format to name plugins of qmmp:
> qmmp-plugin-<group>-<library>   with the Description: Qmmp<Group>  plugin for %s"
> 
> Signed-off-by: Xiaofeng Yan <xiaofeng.yan at windriver.com>
> ---
> .../conf/distro/include/distro_tracking_fields.inc |    9 +++-
> .../qt-apps/{qmmp_0.5.1.bb => qmmp_0.5.2.bb}       |   52 ++++++++++++--------

This should be in a seperate commit

> 
> --- a/meta/recipes-qt/qt-apps/qmmp_0.5.1.bb
> +++ b/meta/recipes-qt/qt-apps/qmmp_0.5.2.bb
> @@ -1,23 +1,24 @@
> -DESCRIPTION = "Qmmp (Qt-based Multimedia Player) is an audio-player, written with help of Qt library"
> +dESCRIPTION = "Qmmp (Qt-based Multimedia Player) is an audio-player, written with help of Qt library"
> HOMEPAGE = "http://qmmp.ylsoftware.com"
> LICENSE = "GPLv2"
> LIC_FILES_CHKSUM = "file://COPYING;md5=393a5ca445f6965873eca0259a17f833"
> SECTION = "multimedia"
> 
> -PR = "r0"
> +PR = "r4"

When upgrading to a new PV you need to reset PR to r0, not increase it


> +PROVIDES = "qmmp"

${PN} is always in provides, no?


> DEPENDS = "qt4-x11-free taglib libmad libvorbis libogg alsa-lib"

please use 'inherit qt4x11' for the qt depends.

> -RDEPENDS_${PN} += "taglib alsa-lib curl"
> +RDEPENDS_${PN} += "taglib alsa-lib libmad curl"

RDEPENDS go below do_install

> 
> SRC_URI = "http://qmmp.ylsoftware.com/files/${BPN}-${PV}.tar.bz2"
> 
> -SRC_URI[md5sum] = "7934c069256bf2fc4ab762ad2683db2f"
> -SRC_URI[sha256sum] = "16ab0334f368a5ef14d631a1d43d7cae876ee06b7185643377b5e9cfd6143099"
> +SRC_URI[md5sum] = "20852f3cce3471bfc5affa9b2e947dc6"
> +SRC_URI[sha256sum] = "6391dec020d2a381d7f4b7890fae6c49eadf88b3c9aef571fe3c5e96140822ec"
> 
> 
> PARALLEL_MAKE = ""

Is this still needed?

> 
> -inherit qmake2 cmake
> +inherit qmake2 cmake package

Why do you inherit package.bbclass here ?!?!?!



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 163 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20111105/a6d7d27f/attachment-0002.sig>