[OE-core] [PATCH 1/2] useradd.bbclass: handle nativesdk case

Scott Garman scott.a.garman at intel.com
Mon Nov 7 23:47:19 UTC 2011


Hi Eric,

Sorry to throw more churn into this, but can I ask you to submit a new 
pull request for this?

In discussions with Richard today, he pointed out a few tricks that 
would improve the patchset:

DEPENDS_append = "${USERADDDEPENDS}"
USERADDDEPENDS = " base-passwd shadow-native shadow-sysroot"
USERADDDEPENDS_virtclass-nativesdk = ""

do_install[prefuncs] += "${SYSROOTFUNC}"
SYSROOTFUNC = "useradd_sysroot"
SYSROOTFUNC_virtclass-nativesdk = ""

I didn't want to take away credit for your patch, so if you'd be willing 
to make these changes and respin your patch set, we'll take that.

The second thing is to avoid merge conflicts, can you rebase you 
patchset on top of this branch:

http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/log/?h=sgarman/useradd-rdepends-final

...and Saul has been warned to apply these patches in the correct order.

Thanks,

Scott

PS - if this is a hassle, just let me know and I'm happy to take care of it.

-- 
Scott Garman
Embedded Linux Engineer - Yocto Project
Intel Open Source Technology Center




More information about the Openembedded-core mailing list