[OE-core] [PATCH 7/7] pango: Fix bug 1674

[Phil Blundell]

On Tue, 2011-11-08 at 19:16 +0800, Xiaofeng Yan wrote:
> -		${@base_contains('DISTRO_FEATURES', 'x11', '--with-x', '--without-x', d)}"
> +		${@base_contains('DISTRO_FEATURES', 'x11', '--with-x', '--without-x', d)} \
> +                ${@base_contains('DISTRO_FEATURES', 'directfb', '--with-x=no', '--with-x=yes', d)}"

That last line looks fairly wrong.  If I am understanding this right
then someone with neither x11 nor directfb set would get "--without-x
--with-x=yes", and someone with directfb but not X would get
"--without-x --with-x=no" which surely can't be what's wanted.  Did you
test this patchset?

>+    [ ! -d "/etc/pango" ] && mkdir -p /etc/pango/

Why can't you just ship this folder in the package rather than creating
it in the postinst?  Also, this should probably be ${sysconfdir} rather
than hardcoded.

p.