[OE-core] [PATCH 0/1] [Yocto Bug 1700] Fix for buildstats diskio on non physical disks

[Flanagan, Elizabeth]

On Wed, Nov 9, 2011 at 4:00 AM, Wolfram Stering <wolfram.stering at hale.at> wrote:
> On 11/08/2011 04:57 PM, Flanagan, Elizabeth wrote:
>> On Tue, Nov 8, 2011 at 7:53 AM, Wolfram Stering <wolfram.stering at hale.at> wrote:
>>> On 11/08/2011 03:12 PM, Richard Purdie wrote:
>>>> On Tue, 2011-11-08 at 11:15 +0100, Wolfram Stering wrote:
>>>>> On 11/02/2011 07:41 AM, Beth Flanagan wrote:
>>>>>> From: Elizabeth Flanagan <elizabeth.flanagan at intel.com>
>>>>>>
>>>>>> tmpfs/encryptfs/ramfs have no entry in /proc/diskstats. This modifies
>>>>>> buildstats to not collect diskio statistics when we encounter a case where
>>>>>> the os.major/os.minor is not represented with an entry in /proc/diskstats.
>>>>> A similar issue exists for building on a btrfs partition.
>>>>> I posted a message on Oct 28 concerning buildstats on btrfs volumes.
>>>>> The problem there is, that btrfs's stat() reports fake device ids that
>>>>> cannot be found in /proc/diskstats.
>>>> Did this patch help address that problem for you too?
>>> I'll be able to check that tomorrow and report back.
>> It should as the patch will just disable diskio collection if it
>> cannot find a valid device id in /proc/diskstats. Let me know if it
>> doesn't and I'll rework it and resubmit.
>>
>> -b
>
> Your patch fixes the buildstats issue for building on a btrfs volume as
> well.
> bitbake no longer hits the exception and diskstats are omitted.
>
> Theoretically, this information would be available for btrfs, but it is
> not discoverable
> in the way buildstats currently collects the disk statistics. However,
> this is a seaprate
> issue, I think.

Yes, and I'm open for suggestions on the best way to implement finding
disk io data for the myriad of filesystem types out there. :/ Or at
the very list  a way to pull diskstats from a trimmed down list that
includes:

ext2/3/4
btrfs
tmpfs
encryptfs....

I'm not sure performance data is even collected for for non-block
devices. dstat and iostat as far as I can tell can't collect data for
tmpfs.

Ideas?

-b

-- 
Elizabeth Flanagan
Yocto Project
Build and Release