[OE-core] [PATCH] shared-mime-info: fix ordering of PACKAGES

Richard Purdie richard.purdie at linuxfoundation.org
Fri Nov 18 14:34:47 UTC 2011


On Fri, 2011-11-18 at 15:28 +0100, Frans Meulenbroeks wrote:
> 
> 
> 2011/11/18 Koen Kooi <koen at dominion.thruhere.net>
>         Signed-off-by: Koen Kooi <koen at dominion.thruhere.net>
>         ---
>          .../shared-mime-info/shared-mime-info.inc          |    2 +-
>          .../shared-mime-info/shared-mime-info_0.91.bb      |    2 +-
>          2 files changed, 2 insertions(+), 2 deletions(-)
>         
>         diff --git
>         a/meta/recipes-support/shared-mime-info/shared-mime-info.inc
>         b/meta/recipes-support/shared-mime-info/shared-mime-info.inc
>         index 57e829c..d7fa67c 100644
>         ---
>         a/meta/recipes-support/shared-mime-info/shared-mime-info.inc
>         +++
>         b/meta/recipes-support/shared-mime-info/shared-mime-info.inc
>         @@ -19,7 +19,7 @@ FILES_${PN}-dev +=
>         "${datadir}/pkgconfig/shared-mime-info.pc"
>         
>          # freedesktop.org.xml is only required when updating the mime
>         database,
>          # package it separately
>         -PACKAGES += "shared-mime-info-data"
>         +PACKAGES =+ "shared-mime-info-data"
>          FILES_shared-mime-info-data =
>         "${datadir}/mime/packages/freedesktop.org.xml"
>          RDEPENDS_shared-mime-info-data = "shared-mime-info"
>         
>         diff --git
>         a/meta/recipes-support/shared-mime-info/shared-mime-info_0.91.bb b/meta/recipes-support/shared-mime-info/shared-mime-info_0.91.bb
>         index bc4a8f7..7ae6e10 100644
>         ---
>         a/meta/recipes-support/shared-mime-info/shared-mime-info_0.91.bb
>         +++
>         b/meta/recipes-support/shared-mime-info/shared-mime-info_0.91.bb
>         @@ -1,5 +1,5 @@
>          require shared-mime-info.inc
>         -PR = "r2"
>         +PR = "r3"
>         
>          SRC_URI[md5sum] = "982a211560ba4c47dc791ccff34e8fbc"
>          SRC_URI[sha256sum] =
>         "98cfebe1d809afb24934e634373821e2a1dfa86fc6462cab230589a1c80988bd"
>         --
>         1.7.2.5
> 
> For my education:
> Is ordering of PACKAGES relevant? If so, please enlighten me why. If
> not why this patch?

Just to cut the story short here, I agree the commit message could have
had more information. There are bug reports on the list related to this
and its clear there is a problem.

I've therefore taken the patch since I'd rather fix this than let more
people fall over the problem over the weekend. In other circumstances I
might have held out for more of a commit message.

Cheers,

Richard






More information about the Openembedded-core mailing list