[OE-core] [RFC PATCH 1/1] qt4: disable pulseaudio

[Koen Kooi]

Op 18 nov. 2011, om 16:03 heeft Paul Eggleton het volgende geschreven:

> Disable pulseaudio support in phonon within Qt4; otherwise it
> auto-detects it and it may be enabled or disabled depending on what gets
> built first.
> 
> Signed-off-by: Paul Eggleton <paul.eggleton at linux.intel.com>
> ---
> meta/recipes-qt/qt4/files/pulseaudio-config.patch |   31 +++++++++++++++++++++
> meta/recipes-qt/qt4/qt-4.7.4.inc                  |    3 +-
> meta/recipes-qt/qt4/qt4-embedded_4.7.4.bb         |    2 +-
> meta/recipes-qt/qt4/qt4-x11-free_4.7.4.bb         |    2 +-
> 4 files changed, 35 insertions(+), 3 deletions(-)
> create mode 100644 meta/recipes-qt/qt4/files/pulseaudio-config.patch
> 
> diff --git a/meta/recipes-qt/qt4/files/pulseaudio-config.patch b/meta/recipes-qt/qt4/files/pulseaudio-config.patch
> new file mode 100644
> index 0000000..5b32815
> --- /dev/null
> +++ b/meta/recipes-qt/qt4/files/pulseaudio-config.patch
> @@ -0,0 +1,31 @@
> +# Allows disabling pulseaudio support within phonon at configure time
> +# 
> +# Upstream-status: pending
> +#
> +# Signed-off-by: Paul Eggleton <paul.eggleton at linux.intel.com>

What follows is a generic question and in no way a criticism or comment on your RFC: Have you thought about using git am'able patches for these things?Upstream for QT is using git, so it would be nice to use somethings as close to the upstream submission as we can get. I've been trying to do this for meta-oe and found it helpfull when coming back to do the actual upstream push later.

regards,

Koen