[OE-core] [PATCH 1/1] intltool: remove XML::Parser check

[Khem Raj]

On Sun, Nov 27, 2011 at 3:37 AM, Richard Purdie
<richard.purdie at linuxfoundation.org> wrote:
> On Sat, 2011-11-26 at 13:36 -0800, Khem Raj wrote:
>> Hi Saul
>>
>> On Sat, Nov 26, 2011 at 10:49 AM, Saul Wold <sgw at linux.intel.com> wrote:
>> > On 11/24/2011 11:37 AM, Khem Raj wrote:
>> >>
>> >> On Thu, Nov 24, 2011 at 10:29 AM, Saul Wold<sgw at linux.intel.com>  wrote:
>> >>>
>> >>> Add Patch to disable the XML::Parser check in the target
>> >>> intltool.m4, this check will find the host (not native)
>> >>> XML::Parser if it's installed possibly causing Host
>> >>> contamination, but will also fail configuration if XML::Parser
>> >>> is not installed on the host.
>> >>>
>> >>> Since we know that XML::Parser is installed on the image, we don't
>> >>> really need this check, so comment it out.
>> >>
>> >> if it is installed then why does it fail to detect it ?
>> >>
>> > Because the recipes that depend on intltool do not inherit perlnative, the
>> > recipes in question are gconf and shared-mime-info.  They depend on
>> > intltool, but do not need to directly inherit perlnative (at least according
>> > to RP).
>>
>> why dont they need to inherit perlnative ? If they depend on intltool which
>> expects that its dependees inherit perlnative. I am just worried where this
>> may cause issues. There might be other recipes which should need XML parser
>> and may not get it since we remove the test here.
>
> All of the intltool scripts have the correct paths to perl already
> embedded into them and can find perl fine.

I see. I think this should be added to comments somewhere may be in
intltool recipe itself
and I hope this also works for target intltool recipe.

If the recipe needs perl for
> some other reason than intltool, it needs perlnative but it if only
> needs perl for intltool, we shouldn't need the dependency. The .m4 macro
> checks are well intended but don't fit the way we use perl. I really
> don't want to end up in a position where intltool automatically means we
> have to add perlnative as a dependency and we've previously seen many
> problems related to that.

agreed.

>
> Cheers,
>
> Richard
>
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>