[OE-core] [oe-core 10/10] gconf: add polkit to DEPENDS

[Martin Jansa]

On Tue, Nov 29, 2011 at 12:49:00PM -0800, Saul Wold wrote:
> On 11/29/2011 12:43 PM, Martin Jansa wrote:
> > On Tue, Nov 29, 2011 at 12:25:46PM -0800, Saul Wold wrote:
> >> On 11/29/2011 06:09 AM, Martin Jansa wrote:
> >>> Signed-off-by: Martin Jansa<Martin.Jansa at gmail.com>
> >>> ---
> >>>    meta/recipes-gnome/gnome/gconf_3.2.3.bb |    2 +-
> >>>    1 files changed, 1 insertions(+), 1 deletions(-)
> >>>
> >>> diff --git a/meta/recipes-gnome/gnome/gconf_3.2.3.bb b/meta/recipes-gnome/gnome/gconf_3.2.3.bb
> >>> index aa9da78..907f0ba 100644
> >>> --- a/meta/recipes-gnome/gnome/gconf_3.2.3.bb
> >>> +++ b/meta/recipes-gnome/gnome/gconf_3.2.3.bb
> >>> @@ -3,7 +3,7 @@ SECTION = "x11/gnome"
> >>>    LICENSE = "LGPLv2+"
> >>>    LIC_FILES_CHKSUM = "file://COPYING;md5=55ca817ccb7d5b5b66355690e9abc605"
> >>>
> >>> -DEPENDS = "glib-2.0 dbus dbus-glib libxml2 intltool-native"
> >>> +DEPENDS = "glib-2.0 dbus dbus-glib libxml2 intltool-native polkit"
> >>>
> >>>    PR = "r1"
> >>>
> >>
> >> What is this solving? This also would require polkit to have a
> >> BBCLASSEXTEND with native.
> >
> > gconf-defaults.c:40:27: fatal error: polkit/polkit.h: No such file or directory
> >
> > most people have polkit build in sysroot and then if you upgrade gconf
> > and polkit at the same time you can get it autodetected in
> > gconf's do_configure and later removed from sysroot while polkit itself
> > is being upgraded.
> >
> > And we probably don't want to disable defaults_service for gconf to force polkit
> > dependency off.
> >
> > HAVE_POLKIT=no
> > AC_ARG_ENABLE(defaults_service,
> >    AS_HELP_STRING([--enable-defaults-service],
> >      [build the defaults DBus service @<:@default=auto@:>@]),
> >    , enable_defaults_service=auto)
> >
> > if test "x$enable_defaults_service" != "xno" ; then
> >    PKG_CHECK_MODULES(DEFAULTS, glib-2.0 gthread-2.0 gobject-2.0 dbus-1 dbus-glib-1 polkit-gobject-1, HAVE_POLKIT=yes, HAVE_POLKIT=no)
> >    if test "x$HAVE_POLKIT" = "xno"; then
> >      if test "x$enable_defaults_service" = "xyes" ; then
> >        AC_MSG_ERROR([[
> > *** Could not find PolicyKit.]])
> >      else
> >        enable_defaults_service=no
> >      fi
> >    else
> >      enable_defaults_service=yes
> >    fi
> > fi
> >
> > Weird it didn't fail for me without polkit-native (there isn't .bbappend in any of
> > my layers and I've even tested it in distro less oe-core), but you're right, we should
> > provide polkit-native or disable defaults_service for native gconf.
> >
> I think it would be best to disable the default_services for native 
> gconf, a patch for that would be great, thanks

Ah, now I know why I haven't seen that in normal builds
/OE/shr-core/meta-openembedded/meta-gnome/recipes-gnome/gconf/gconf-native_2.6.1.bb

and nothing in my oe-core-only builds was depending on gconf-native

I'll send updated patch after few more tests..

Cheers,
-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20111129/616c2f12/attachment-0002.sig>