[OE-core] [PATCH 1/4] gmp: also generate the libgmpcxx library & package it properly

Phil Blundell philb at gnu.org
Tue Nov 29 22:05:47 UTC 2011


On Tue, 2011-11-29 at 13:08 -0800, Kamble, Nitin A wrote:
> > Um, why does this patch have my name in Signed-off-by?
>
> Because I took the code from your email.

Ah, I see.  Well, I appreciate you giving me the credit for that, and in
this particular instance I don't have a problem with it, but as a
general rule it isn't the done thing to add "Signed-off-by" lines naming
other people.  A note in the commit message saying that you'd taken the
code from my email would have been fine.

p.






More information about the Openembedded-core mailing list