[OE-core] [PATCH] consolekit: package /var/log/Consolekit

[Richard Purdie]

On Wed, 2011-11-30 at 21:39 +0100, Koen Kooi wrote:
> Op 30 nov. 2011, om 21:19 heeft Richard Purdie het volgende geschreven:
> 
> > On Wed, 2011-11-30 at 18:50 +0100, Koen Kooi wrote:
> >> Op 30 nov. 2011, om 18:38 heeft Richard Purdie het volgende geschreven:
> >> 
> >>> On Wed, 2011-11-30 at 09:24 +0100, Koen Kooi wrote:
> >>>> This fixes startup issues like this:
> >>>> 
> >>>> 2011-11-30T09:02:10+01:00 beaglebone ck-log-system-start[91]: **
> >>>> (process:91): WARNING **: Couldn't create log
> >>>> file /var/log/ConsoleKit/history (No such file or directory)
> >>>> 
> >>>> Signed-off-by: Koen Kooi <koen at dominion.thruhere.net>
> >>>> ---
> >>>> .../recipes-support/consolekit/consolekit_0.4.5.bb |    4 ++--
> >>>> 1 files changed, 2 insertions(+), 2 deletions(-)
> >>>> 
> >>>> diff --git a/meta/recipes-support/consolekit/consolekit_0.4.5.bb b/meta/recipes-support/consolekit/consolekit_0.4.5.bb
> >>>> index 562dfb3..a02203c 100644
> >>>> --- a/meta/recipes-support/consolekit/consolekit_0.4.5.bb
> >>>> +++ b/meta/recipes-support/consolekit/consolekit_0.4.5.bb
> >>>> @@ -2,7 +2,7 @@ DESCRIPTION = "ConsoleKit is a framework for defining and tracking users, login
> >>>> HOMEPAGE="http://www.freedesktop.org/wiki/Software/ConsoleKit"
> >>>> BUGTRACKER="https://bugs.freedesktop.org/buglist.cgi?query_format=specific&product=ConsoleKit"
> >>>> 
> >>>> -PR = "r5"
> >>>> +PR = "r6"
> >>>> 
> >>>> LICENSE = "GPLv2+"
> >>>> LIC_FILES_CHKSUM = "file://COPYING;md5=59530bdf33659b29e73d4adb9f9f6552 \
> >>>> @@ -23,7 +23,7 @@ EXTRA_OECONF = "--with-systemdsystemunitdir=${base_libdir}/systemd/system/ \
> >>>>                ${@base_contains('DISTRO_FEATURES', 'pam', '--enable-pam-module --with-pam-module-dir=${base_libdir}/security', '--disable-pam-module', d)} \
> >>>>               "
> >>>> 
> >>>> -FILES_${PN} += "${libdir}/ConsoleKit ${base_libdir} ${datadir}/dbus-1 ${datadir}/PolicyKit ${datadir}/polkit*"
> >>>> +FILES_${PN} += "${localstatedir}/log/ConsoleKit ${libdir}/ConsoleKit ${base_libdir} ${datadir}/dbus-1 ${datadir}/PolicyKit ${datadir}/polkit*"
> >>>> FILES_${PN}-dbg += "${base_libdir}/security/.debug"
> >>>> 
> >>>> PACKAGES =+ "pam-plugin-ck-connector"
> >>> 
> >>> Looks like this is breaking builds:
> >>> 
> >>> | consolekit                  ##################################################
> >>> | error: unpacking of archive failed on file /var/log: cpio: rename failed - Invalid argument
> >>> 
> >>> :(
> >>> 
> >>> http://autobuilder.pokylinux.org:8010/builders/nightly-x86-64/builds/197/steps/shell_30/logs/stdio
> >> 
> >> I suspect that's another victim of fs-perms.txt and rpm, it seems to
> >> break if /var/log is a symlink in other packages. I am going to argue
> >> that the breakage isn't a bug in consolekit :)
> > 
> > I really don't care whether its a bug in consolekit or not. The point is
> > that builds that were working before this change are now broken and we
> > have a regression.
> > 
> > Who is going to fix the regression?
> > 
> > Someone told me the answer is easy, I just revert the appropriate patch.
> > I tend to take on a lot of these types of issues and silently fix them
> > but I really need some help with it...
> 
> What I did for angstrom a while ago is to use a custom fsperms.txt
> that stays out of /var. That's why I'm not seeing this bug :)

I suspect the reason you're not seeing the bug is:

http://git.angstrom-distribution.org/cgi-bin/cgit.cgi/meta-angstrom/tree/recipes-core/base-files/base-files_3.0.14.bbappend

which then in turn needed a changed fsperms.txt.

I do have a way we can fix this which is to add:

RDEPENDS_${PN} = "base-files"

which ensures base-files sets up the directory structure first. I'm
going to push that and unbreak the builds that way rather than the
alternative which would be to revert it.

Cheers,

Richard