[OE-core] [oe-core][PATCHv2 04/30] xf86-video-omapfb: bump SRCREV and add patch from meta-oe

[Phil Blundell]

On Mon, 2011-10-03 at 15:28 +0200, Martin Jansa wrote:
> From: Martin Jansa <martin.jansa at gmail.com>
> 
> Signed-off-by: Martin Jansa <Martin.Jansa at gmail.com>
> Signed-off-by: Richard Purdie <richard.purdie at linuxfoundation.org>
> Signed-off-by: Martin Jansa <Martin.Jansa at gmail.com>
> ---

This is a bit of a lame checkin message.  "Add patch from meta-oe"
doesn't really say anything useful about what you're changing, and there
is no long comment at all.  Also ...

>@@ -1,25 +1,25 @@
>-require xorg-driver-driver.inc
>+require xorg-driver-video.inc
> 
> SUMMARY = "X.Org X server -- Texas Instruments OMAP framebuffer driver"
>
> DESCRIPTION = "omapfb driver supports the basic Texas Instruments OMAP \
> framebuffer."
>
>-LICENSE = "MIT-X"
>-LIC_FILES_CHKSUM = "file://src/omapfb-driver.c;beginline=1;endline=30;md5=a44c2a37e04d1c2c5f0313afb493f833"
>+LICENSE = "MIT-X & GPLv2+"
>+LIC_FILES_CHKSUM = "file://COPYING;md5=63e2cbac53863f60e2f43343fb34367f"
> DEPENDS += "virtual/libx11"

... these changes don't seem to be covered by the description above.

And, finally, if this is an OMAP-specific driver, why is it in oe-core
in the first place?  I would have thought it would be better placed in
meta-ti or some such layer.

p.