[OE-core] [PATCH 2/8] libatomics-ops: force ARM mode

[Mark Hatle]

On 10/21/11 3:17 AM, Martin Jansa wrote:
> * otherwise ie spitz (armv5te) build fails with:
> | make[3]: Entering directory `/OE/shr-core/tmp/work/armv5te-oe-linux-gnueabi/libatomics-ops-1.2-r5/libatomic_ops-1.2/src'
> | arm-oe-linux-gnueabi-gcc  -march=armv5te  -mthumb -mthumb-interwork  -mtune=xscale --sysroot=/OE/shr-core/tmp/sysroots/spitz -DHAVE_CONFIG_H -I.    -fPIC -O
> 2 -pipe -g -feliminate-unused-debug-types -DNDEBUG -c atomic_ops.c
> | arm-oe-linux-gnueabi-gcc  -march=armv5te  -mthumb -mthumb-interwork  -mtune=xscale --sysroot=/OE/shr-core/tmp/sysroots/spitz -DHAVE_CONFIG_H -I.    -fPIC -O
> 2 -pipe -g -feliminate-unused-debug-types -DNDEBUG -c atomic_ops_stack.c
> | arm-oe-linux-gnueabi-gcc  -march=armv5te  -mthumb -mthumb-interwork  -mtune=xscale --sysroot=/OE/shr-core/tmp/sysroots/spitz -DHAVE_CONFIG_H -I.    -fPIC -O
> 2 -pipe -g -feliminate-unused-debug-types -DNDEBUG -c atomic_ops_malloc.c
> | atomic_ops_malloc.c: In function 'msb':
> | atomic_ops_malloc.c:223:2: warning: right shift count >= width of type [enabled by default]
> | rm -f libatomic_ops_gpl.a
> | ar cru libatomic_ops_gpl.a atomic_ops_stack.o atomic_ops_malloc.o
> | arm-oe-linux-gnueabi-ranlib libatomic_ops_gpl.a
> | {standard input}: Assembler messages:
> | {standard input}:286: Error: selected processor does not support Thumb mode `swp r1,r2,[r3]'
> | {standard input}:329: Error: selected processor does not support Thumb mode `swp r0,r1,[r3]'
> 
> Signed-off-by: Martin Jansa <Martin.Jansa at gmail.com>
> ---
>  .../pulseaudio/libatomics-ops_1.2.bb               |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/meta/recipes-multimedia/pulseaudio/libatomics-ops_1.2.bb b/meta/recipes-multimedia/pulseaudio/libatomics-ops_1.2.bb
> index 05b22e8..4d9ca0d 100644
> --- a/meta/recipes-multimedia/pulseaudio/libatomics-ops_1.2.bb
> +++ b/meta/recipes-multimedia/pulseaudio/libatomics-ops_1.2.bb
> @@ -20,4 +20,6 @@ S = "${WORKDIR}/libatomic_ops-${PV}"
>  
>  ALLOW_EMPTY_${PN} = "1"
>  
> +ARM_INSTRUCTION_SET = "arm"
> +
>  inherit autotools pkgconfig

Wouldn't it be better to fix libatomic-ops to have proper thumb mode assembly,
then fall back to non-thumb assembly?

I swear I had a patch to do this in the past, but I'm currently not able to find it.

--Mark