[OE-core] [PATCH 0/1] Fix MakeMaker's finding of perl.real

Richard Purdie richard.purdie at linuxfoundation.org
Wed Sep 7 22:42:42 UTC 2011


On Wed, 2011-09-07 at 11:07 +0200, Anders Darander wrote:
> * Eric Bénard <eric at eukrea.com> [110907 08:41]:
> > Le 07/09/2011 07:09, Saul Wold a écrit :
> > > When configuring cpan packages, the directories passed to MakeMaker are the
> > > target directories. There was a patch that was applied to the native perl
> > > to find perl.real and convert that to perl.  This does not apply for the
> > > target perl modules and therefore MakeMaker find perl.real.
> > >
> > > This patch to cpan configure modifies the Makefile after configure and
> > > changes the perl.real to just straight perl so we have the correct paths
> > > and shared state info in usable.
> > >
> > when sending 1 patch, is it possible to not use cover letter in order to have
> > the explanation in the patch commit ?
> > That's easier to understand what the patch is doing when browsing log.
> 
> Cover letter or not, the patch should include a commit message that
> explains the patch. It doesn't really matter if there is only one patch
> or a large patch series.
> 
> For a single patch, the cover letter can be usefull to provide some
> extra information and discussion. In other cases, it can be pretty
> useless IMHO.

This commit has slipped into the tree this time but I agree in future
more explanation of a commit is needed...

Cheers,

Richard





More information about the Openembedded-core mailing list