[OE-core] [PATCH] pango: use qemu to generate pango.modules during rootfs construction

[Richard Purdie]

On Fri, 2011-09-09 at 14:19 -0700, Saul Wold wrote:
> On 08/31/2011 08:35 AM, Phil Blundell wrote:
> > This allows pango to be installed in an image with read-only-rootfs.
> >
> > Signed-off-by: Phil Blundell<philb at gnu.org>
> > ---
> >   meta/recipes-graphics/pango/pango.inc       |   11 +++++++----
> >   meta/recipes-graphics/pango/pango_1.28.4.bb |    2 +-
> >   2 files changed, 8 insertions(+), 5 deletions(-)
> >
> > diff --git a/meta/recipes-graphics/pango/pango.inc b/meta/recipes-graphics/pango/pango.inc
> > index a8e99e2..ff3f5dd 100644
> > --- a/meta/recipes-graphics/pango/pango.inc
> > +++ b/meta/recipes-graphics/pango/pango.inc
> > @@ -10,13 +10,13 @@ SECTION = "libs"
> >   LICENSE = "LGPL"
> >
> >   X11DEPENDS = "virtual/libx11 libxft"
> > -DEPENDS = "glib-2.0 fontconfig freetype zlib virtual/libiconv gtk-doc-native cairo ${@base_contains('DISTRO_FEATURES', 'x11', '${X11DEPENDS}', '', d)}"
> > +DEPENDS = "glib-2.0 fontconfig freetype zlib virtual/libiconv gtk-doc-native cairo qemu-native ${@base_contains('DISTRO_FEATURES', 'x11', '${X11DEPENDS}', '', d)}"
> >
> >   PACKAGES_DYNAMIC = "pango-module-*"
> >
> >   RRECOMMENDS_${PN} = "${@base_contains('DISTRO_FEATURES', 'x11', 'pango-module-basic-x', '', d)} pango-module-basic-fc"
> >
> > -inherit gnome
> > +inherit gnome qemu
> >
> >   EXTRA_AUTORECONF = ""
> >
> > @@ -33,9 +33,12 @@ LIBV = "1.6.0"
> >
> >   postinst_prologue() {
> >   if [ "x$D" != "x" ]; then
> > -  exit 1
> > +	if [ ! -f "$D${sysconfdir}/pango/pango.modules" ]; then
> > +		mkdir -p $D${sysconfdir}/pango
> > +		PSEUDO_RELOADED=YES ${@qemu_target_binary(d)} -L $D $D${bindir}/pango-querymodules>  "$D${sysconfdir}/pango/pango.modules"
> > +	fi
> > +	exit 0
> >   fi
> > -
> >   }
> >
> The usage here of qemu, and some further testing has shown that this may 
> not be the best time to put this patch in, There are failures in both 
> x86-64 and arm builds and the newer version of qemu does not appear to 
> resolve this.
> 
> Phil, given we are trying to generate a release at this point, I feel 
> that we need to revert this patch. You are welcome to resubmit an 
> updated version with sufficient test results, but it will be to master 
> and not 1.1.
> 
> Thanks for the efforts to create a read-only rootfs, this one just can't 
> make it this time.

For what its worth, even on plain qemux86 I'm seeing:

qemu: Unsupported syscall: 240
inb: port=0x0000
qemu: uncaught target signal 11 (Segmentation fault) - core dumped
/media/data1/build1/poky/build/tmp/work/qemux86-poky-linux/core-image-sato-1.0-r0/rootfs/etc/rpm-postinsts/pango-module-basic-fc.sh: line 8: 11084 Segmentation fault      PSEUDO_RELOADED=YES qemu-i386 -L $D $D/usr/bin/pango-querymodules > "$D/etc/pango/pango.modules"

in the rootfs logs. Which reading things online suggests that qemu
doesn't support multithreading under qemu user emulation on i386.

I therefore think we're going to have to rethink this patch...

Cheers,

Richard