[OE-core] [PATCH 1/1] tune-mips32: Update the default MIPS tuning to be mips32

Phil Blundell philb at gnu.org
Tue Apr 10 12:35:15 UTC 2012


On Mon, 2012-04-09 at 18:31 -0500, Mark Hatle wrote:
> Previously the default mips tuning was defined as "mips1"
> internally in the compiler.  Revise this and change to "mips32".
> 
> This eliminates the need for the mips32 specific tunings, which were
> not being used anyway.  (They exists and were used, but were not
> differentiated by package arch prior to a recent commit.)

This change is slightly more far-reaching than the description above
suggests, in that it isn't just changing the default tuning: it seems
actually to remove the ability to tune for pre-mips32 altogether.
Obviously there's nothing to stop anybody creating tune files for
earlier MIPS in some other BSP layer, but this is a feature that exists
in oe-core today and would be removed by this patch.

Also, the second paragraph of your checkin message above doesn't make a
lot of sense.  In the first sentence you say that the mips32 tunings
were not being used, and then in the second sentence you say that they
were.  It doesn't seem that both those statements can logically be true.

And, finally, the checkin message doesn't make it entirely clear why
this change represents an improvement, i.e. why MIPS32 is a better
default tune than MIPS I.

p.






More information about the Openembedded-core mailing list