[OE-core] [PATCH 1/1] gdk-pixbuf: Add --with-x11 when building lsb image

[Koen Kooi]

Op 24 apr. 2012, om 08:12 heeft Xiaofeng Yan het volgende geschreven:

> On 2012年04月24日 13:53, Koen Kooi wrote:
>> Op 24 apr. 2012, om 07:50 heeft Xiaofeng Yan het volgende geschreven:
>> 
>> 
>>> From: Xiaofeng Yan <xiaofeng.yan at windriver.com>
>>> 
>>> 
>>> LSB Test Suite complain "no library libgdk_pixbuf_xlib-2.0.so.0" \
>>> because of having "--without-x11" for gdk-pixbuf_2.24.1.bb.
>>> For passing lsb test I add PACKAGECONFIG support to the recipe and \
>>> have poky-lsb turn on the poky-lsb distro for this recipe.
>>> 
>>> [YOCTO #2284]
>>> 
>> Shouldn't this be an 'x11' DISTRO_FEATURE instead?
>> 
> because "--without-x11" is disabled when x11 exists in core-image-sato. Using 'x11' DISTRO_FEATURE instead will change the default set, which will cause enable "--with-x11" when x11 is in DISTRO_FEATURE. LSB Test Suite need this configuration but other image may not need it even if having x11.

What use-case is there for having 'x11' in DISTRO_FEATURES but not wanting x11 support in pixbuf?

Regardless of that, poky-lsb distro overrides have no place in oe-core, they should go into their own layer as bbappends.

regards,

Koen