[OE-core] v2 [PATCH 2/2] sanity.bbclass: Implement initial toolchain sanity checks

Khem Raj raj.khem at gmail.com
Sat Apr 28 23:42:31 UTC 2012


On Fri, Apr 27, 2012 at 5:01 PM, Peter Seebach
<peter.seebach at windriver.com> wrote:
> +    valid_tunes = data.getVarFlags('TUNEVALID') or ""
> +    conflicts = data.getVarFlags('TUNECONFLICTS') or ""
> +    split_conflicts = {}
> +    for feature in features:
> +        if feature in conflicts:
> +            if feature not in split_conflicts:
> +                split_conflicts[feature] = conflicts[feature].split()
> +            for other in features:
> +                if other in split_conflicts[feature]:
> +                    tune_errors.append("Feature '%s' conflicts with '%s'." %
> +                        ( feature, other ))
> +        if feature in valid_tunes:
> +            bb.note("  %s: %s" % (feature, valid_tunes[feature]))
> +        else:
> +            tune_errors.append("Feature '%s' is not defined." % feature)


can this piece be simplified. ? may be using sets or some other python contructs
I think its quite difficult to comprehend for me whats going on here




More information about the Openembedded-core mailing list