[OE-core] u-boot do_compile should be reentrant even with ld-is-gold

Martin Jansa martin.jansa at gmail.com
Thu Aug 2 14:37:05 UTC 2012


On Thu, Aug 02, 2012 at 07:30:38AM -0700, Khem Raj wrote:
> 
> On Aug 2, 2012, at 4:50 AM, Martin Jansa <martin.jansa at gmail.com> wrote:
> 
> > On Wed, Aug 01, 2012 at 04:02:24PM -0700, Khem Raj wrote:
> >> 
> >> On Jul 31, 2012, at 11:54 PM, Martin Jansa <martin.jansa at gmail.com> wrote:
> >> 
> >>> well not exactly like this one as this is causing
> >>> /bin/sh: 1: Syntax error: Bad fd number
> >>> probably from ">&" in dash
> >> 
> >> 
> >> yes. I swear I have since fixed this patch this seems to be an older version
> >> did you look into meta-ti/master ?
> > 
> > Yes, your patch is fixed in meta-ti, but cannot be used together with
> > Otavio's patch to u-boot.inc.
> > 
> > meta-ti is fine because it provides own u-boot.inc, but with your patch
> > and u-boot.inc from oe-core it ends like this
> 
> 
> so why don't you migrate the patch from meta-ti into OE-Core ? and leave this sed
> thing out ?

Because all layers using u-boot.inc from oe-core probably already have
this patch and adding it to oe-core too will cause do_patch to fail.

Or those layers are not using SRC_URI from u-boot.inc and then they
won't get this patch anyway.

And I don't want to introduce another kind of automagic which would
add that patch to SRC_URI only if it's not added by some .bbappend
already.. 

One character change in that regexp fixed all use-cases I can think of,
so looks like best solution to me..

Cheers,

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20120802/c9142063/attachment-0002.sig>


More information about the Openembedded-core mailing list