[OE-core] [PATCH 11/30] lsb: use ${base_bindir} instead of /bin for packaging

Mark Hatle mark.hatle at windriver.com
Mon Aug 6 17:29:04 UTC 2012


On 8/5/12 10:53 AM, Javier Martinez Canillas wrote:
> It is considered good practice to use the build system provided
> variables instead of directly specify hardcoded paths.
>
> Signed-off-by: Javier Martinez Canillas <javier at dowhile0.org>
> ---
>   meta/recipes-extended/lsb/lsb_1.4.bb |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/recipes-extended/lsb/lsb_1.4.bb b/meta/recipes-extended/lsb/lsb_1.4.bb
> index 15dbeaa..5734c5c 100644
> --- a/meta/recipes-extended/lsb/lsb_1.4.bb
> +++ b/meta/recipes-extended/lsb/lsb_1.4.bb
> @@ -23,7 +23,7 @@ S = "${WORKDIR}/lsb-release-${PV}"
>
>   do_install(){
>   	oe_runmake install prefix=${D}  mandir=${D}/${datadir}/man/ DESTDIR=${D}
> -	mkdir -p ${D}/bin
> +	mkdir -p ${D}${base_bindir}
>   	mkdir -p ${D}/${baselib}
>   	mkdir -p ${D}/etc/lsb-release.d
>   	echo -n "LSB_VERSION=\"core-4.1-noarch:" > ${D}/etc/lsb-release
>

This is another case with the lsb, that lsb-release (and a few other things) are 
documented to me installed into /bin.

Not objecting to the change, just explaining why it was implemented this way.

--Mark




More information about the Openembedded-core mailing list