[OE-core] [oe-commits] Jackie Huang : gdk-pixbuf: fix the postinstall script failure when no icon is installed

[Martin Jansa]

On Wed, Aug 15, 2012 at 01:32:02PM +0000, git at git.openembedded.org wrote:
> Module: openembedded-core.git
> Branch: master
> Commit: 1d4fbe4761d3d97e3c4b6e894719ee41b21559b2
> URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=1d4fbe4761d3d97e3c4b6e894719ee41b21559b2
> 
> Author: Jackie Huang <jackie.huang at windriver.com>
> Date:   Thu Aug  9 10:30:30 2012 +0800
> 
> gdk-pixbuf: fix the postinstall script failure when no icon is installed
> 
> If gtk+ is added to core-image-minimal, postinstall script failed on boot:
> 
> Running postinst /etc/rpm-postinsts/104...
> gtk-update-icon-cache: No theme index file.
> ERROR: postinst /etc/rpm-postinsts/104 failed.
> 
> This patch fixed the postinstall script to check for the icon
> file first and not run the gtk-update-icon-cache if no icon
> is installed.
> 
> [YOCTO #2905]
> 
> Signed-off-by: Jackie Huang <jackie.huang at windriver.com>
> Signed-off-by: Saul Wold <sgw at linux.intel.com>


Even with this patch I get:
Configuring gdk-pixbuf-loader-png.
gtk-update-icon-cache: No theme index file.
Configuring gdk-pixbuf-loader-jpeg.
gtk-update-icon-cache: No theme index file.
Configuring gdk-pixbuf-loader-xpm.
gtk-update-icon-cache: No theme index file.
Configuring gdk-pixbuf-loader-gif.
gtk-update-icon-cache: No theme index file.
Collected errors:
 * pkg_run_script: package "gdk-pixbuf-loader-png" postinst script
 * returned status 1.
 * opkg_configure: gdk-pixbuf-loader-png.postinst returned 1.
 * pkg_run_script: package "gdk-pixbuf-loader-jpeg" postinst script
 * returned status 1.
 * opkg_configure: gdk-pixbuf-loader-jpeg.postinst returned 1.
 * pkg_run_script: package "gdk-pixbuf-loader-xpm" postinst script
 * returned status 1.
 * opkg_configure: gdk-pixbuf-loader-xpm.postinst returned 1.
 * pkg_run_script: package "gdk-pixbuf-loader-gif" postinst script
 * returned status 1.
 * opkg_configure: gdk-pixbuf-loader-gif.postinst returned 1.

And even worse on other device, where gtk-update-icon-cache failed with 
Illegal instruction when postinst was executed for first time.. (probably 
because of binutils-2.23)

SHR root at gjama ~ $ gtk-update-icon-cache -q /usr/share/icons/shr/
Illegal instruction

Configuring gdk-pixbuf-loader-png.
gtk-update-icon-cache: Failed to open file /usr/share/icons/gnome/.icon-theme.cache : File exists
gtk-update-icon-cache: Failed to open file /usr/share/icons/hicolor/.icon-theme.cache : File exists
gtk-update-icon-cache: Failed to open file /usr/share/icons/shr/.icon-theme.cache : File exists
gtk-update-icon-cache: No theme index file.
Configuring gdk-pixbuf-loader-jpeg.
gtk-update-icon-cache: Failed to open file /usr/share/icons/gnome/.icon-theme.cache : File exists
gtk-update-icon-cache: Failed to open file /usr/share/icons/hicolor/.icon-theme.cache : File exists
gtk-update-icon-cache: Failed to open file /usr/share/icons/shr/.icon-theme.cache : File exists
gtk-update-icon-cache: No theme index file.
Configuring gdk-pixbuf-loader-xpm.
gtk-update-icon-cache: Failed to open file /usr/share/icons/gnome/.icon-theme.cache : File exists
gtk-update-icon-cache: Failed to open file /usr/share/icons/hicolor/.icon-theme.cache : File exists
gtk-update-icon-cache: Failed to open file /usr/share/icons/shr/.icon-theme.cache : File exists
gtk-update-icon-cache: No theme index file.
Configuring gdk-pixbuf-loader-gif.
gtk-update-icon-cache: Failed to open file /usr/share/icons/gnome/.icon-theme.cache : File exists
gtk-update-icon-cache: Failed to open file /usr/share/icons/hicolor/.icon-theme.cache : File exists
gtk-update-icon-cache: Failed to open file /usr/share/icons/shr/.icon-theme.cache : File exists
gtk-update-icon-cache: No theme index file.
Collected errors:
 * pkg_run_script: package "gdk-pixbuf-loader-png" postinst script returned status 1.
 * opkg_configure: gdk-pixbuf-loader-png.postinst returned 1.
 * pkg_run_script: package "gdk-pixbuf-loader-jpeg" postinst script returned status 1.
 * opkg_configure: gdk-pixbuf-loader-jpeg.postinst returned 1.
 * pkg_run_script: package "gdk-pixbuf-loader-xpm" postinst script returned status 1.
 * opkg_configure: gdk-pixbuf-loader-xpm.postinst returned 1.
 * pkg_run_script: package "gdk-pixbuf-loader-gif" postinst script returned status 1.
 * opkg_configure: gdk-pixbuf-loader-gif.postinst returned 1.


> 
> ---
> 
>  meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb |   10 ++++++++--
>  1 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb
> index 484fb12..159bdae 100644
> --- a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb
> +++ b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb
> @@ -21,7 +21,7 @@ SRC_URI = "http://ftp.acc.umu.se/pub/GNOME/sources/gdk-pixbuf/2.24/gdk-pixbuf-${
>  SRC_URI[md5sum] = "72f39b34b20f68148c1609bd27415412"
>  SRC_URI[sha256sum] = "da7a3f00db360913716368e19e336402755cafa93769f3cfa28a969303e4bee1"
>  
> -PR = "r4"
> +PR = "r5"
>  
>  inherit autotools pkgconfig gettext
>  
> @@ -62,7 +62,13 @@ fi
>  
>  GDK_PIXBUF_MODULEDIR=${libdir}/gdk-pixbuf-2.0/${LIBV}/loaders gdk-pixbuf-query-loaders --update-cache
>  
> -test -x ${bindir}/gtk-update-icon-cache && gtk-update-icon-cache  -q ${datadir}/icons/hicolor
> +if [ -x ${bindir}/gtk-update-icon-cache ] && [ -d ${datadir}/icons ]; then
> +    for icondir in /usr/share/icons/*; do
> +        if [ -d ${icondir} ]; then
> +            gtk-update-icon-cache -q ${icondir}
> +        fi
> +    done
> +fi
>  }
>  
>  PACKAGES_DYNAMIC += "gdk-pixbuf-loader-*"
> 
> 
> _______________________________________________
> Openembedded-commits mailing list
> Openembedded-commits at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-commits

-- 
Martin 'JaMa' Jansa     jabber: Martin.Jansa at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20120816/66b7810e/attachment-0002.sig>