[OE-core] [PATCH 1/1] quota 4.00: add DEPENDS gettext-native

[jhuang0]

On 7/24/2012 1:17 PM, jhuang0 wrote:
>
>
> On 7/23/2012 6:00 PM, Richard Purdie wrote:
>> On Mon, 2012-07-23 at 16:38 +0800, jackie.huang at windriver.com wrote:
>>> From: Jackie Huang<jackie.huang at windriver.com>
>>>
>>> do_install needs command 'msgfmt', it would fail if the command
>>> doesn't exist on the host, add DEPENDS gettext-native to fix this.
>>>
>>> [YOCTO #2811]
>>>
>>> Signed-off-by: Jackie Huang<jackie.huang at windriver.com>
>>> ---
>>>   meta/recipes-extended/quota/quota_4.00.bb |    2 ++
>>>   1 files changed, 2 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/meta/recipes-extended/quota/quota_4.00.bb
>>> b/meta/recipes-extended/quota/quota_4.00.bb
>>> index 5fef9cb..25f6381 100644
>>> --- a/meta/recipes-extended/quota/quota_4.00.bb
>>> +++ b/meta/recipes-extended/quota/quota_4.00.bb
>>> @@ -15,6 +15,8 @@ SRC_URI[sha256sum] =
>>> "eb2b045f58b98299edc568b8607b95b10735b4a131fa5196f41c89b51f
>>>
>>>   S = "${WORKDIR}/quota-tools"
>>>
>>> +DEPENDS = "gettext-native"
>>> +
>>>   inherit autotools
>>>
>>>   EXTRA_OEMAKE += 'STRIP=""'
>>
>> Shouldn't this be "inherit gettext" ?
>
> No, quota doesn't depend on gettext at runtime, so I don't think we need
> 'inherit gettext'.

quota only needs command 'msgfmt' which provied by gettext in 
do_install, so I don't think we need 'inherit gettext' to both depends 
on gettext-native and virtual/gettext. Could anyone explain why we 
should use 'inherit gettext' instead of just depending on gettext-native?

Thanks,
Jackie

>
> Thanks,
> Jackie
>
>>
>> Cheers,
>>
>> Richard
>>
>>
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core at lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>>
>>
>

-- 
Jackie Huang
WIND RIVER | China Development Center
MSN:jackielily at hotmail.com
Tel: +86 8477 8594
Mobile: +86 138 1027 4745