[OE-core] [PATCH 1/1] ia32-base.inc: new include file

Richard Purdie richard.purdie at linuxfoundation.org
Sat Aug 25 11:53:21 UTC 2012


On Sat, 2012-08-25 at 01:13 -0700, Khem Raj wrote:
> 
> 
> On Saturday, August 25, 2012, Koen Kooi <koen at dominion.thruhere.net>
> wrote:
> >
> > Op 25 aug. 2012, om 06:34 heeft tom.zanussi at intel.com het volgende
> geschreven:
> >
> >> From: Tom Zanussi <tom.zanussi at intel.com>
> >>
> >> This is the ia32-base.inc moved over from meta-intel.  See
> meta-intel
> >> for the complete history of contributions to this file.
> >>
> >> Here's the initial commit text that explains the purpose of this
> file:
> >>
> >>  The meta-intel BSPs currently have a number of machine settings
> common
> >>  to all - factor these out into a common include file.
> >>
> >>  Also add several new intel-specific XSERVER variables for building
> >>  XSERVER variables in BSPs.
> >>
> >> Signed-off-by: Tom Zanussi <tom.zanussi at intel.com>
> >> ---
> >> meta/conf/machine/include/ia32-base.inc | 58
> +++++++++++++++++++++++++++++++++
> >>
> >> +# glibc-related variables
> >> +#
> >> +GLIBC_ADDONS ?= "nptl"
> >
> > That's a distro setting
> 
> And its redundant

I thought you tried removing this and we ran into issues?

Regardless, I think this is reason to have this in one place where we
can clean it up. I tried to untangle the GLIBC_EXTRA_CONF bit that was
here until recently and that was more painful than necessary needing
patches to meta-intel and meta-yocto. If we get one good include file,
we then have one place to clean this kind of thing up and it stops BSP
layers having to do their own things badly.

So in summary I think this is a reason to support this change :)

Cheers,

Richard








More information about the Openembedded-core mailing list