[OE-core] [PATCH V2] base-files: provide a mechanism to skip creation of the hostname file

Phil Blundell philb at gnu.org
Tue Aug 28 18:38:04 UTC 2012


On Tue, 2012-08-28 at 14:20 -0400, Mark Asselstine wrote:
> +	if [ "${hostname}" != "none" ]; then

This magic string value seems a bit unwholesome.  Can't you just check
against the empty string?

Also, if the problem is that the static hostname set here is overriding
the one from dhcp or the command line, I wonder whether this just
indicates that the priority of them is wrong and the scripting should be
adjusted so that the static file has lower priority than the other two
things.

p.






More information about the Openembedded-core mailing list