[OE-core] [PATCH 2/5] rootfs generation: export two new variables to postinst scriptlets
Richard Purdie
richard.purdie at linuxfoundation.org
Wed Dec 5 15:30:41 UTC 2012
On Tue, 2012-12-04 at 13:07 -0200, Otavio Salvador wrote:
>
>
>
> On Tue, Dec 4, 2012 at 11:59 AM, Laurentiu Palcu
> <laurentiu.palcu at intel.com> wrote:
> In order for the postinst scriptlets to be able to run once we
> need to
> export the location of the intercept scripts and also the
> location of
> native sysrootfs. The gdk-pixbuf binaries will need the latter
> because
> in order to generate the loaders.cache it will need to scan
> some shared
> libraries that must be native. Even though the output is a
> text file.
>
> Signed-off-by: Laurentiu Palcu <laurentiu.palcu at intel.com>
> ---
> meta/classes/package_rpm.bbclass | 2 ++
> meta/classes/rootfs_deb.bbclass | 2 ++
> meta/classes/rootfs_ipk.bbclass | 2 ++
> 3 files changed, 6 insertions(+)
>
> diff --git a/meta/classes/package_rpm.bbclass
> b/meta/classes/package_rpm.bbclass
> index 1ff92ce..c7ac07a 100644
> --- a/meta/classes/package_rpm.bbclass
> +++ b/meta/classes/package_rpm.bbclass
> @@ -475,6 +475,8 @@ export D="${target_rootfs}"
> export OFFLINE_ROOT="\$D"
> export IPKG_OFFLINE_ROOT="\$D"
> export OPKG_OFFLINE_ROOT="\$D"
> +export INTERCEPT_DIR="${WORKDIR}/intercept_scripts"
> +export NATIVE_ROOT=${STAGING_DIR_NATIVE}
>
>
> The NATIVE_ROOT seems a duplication, I'd prefer you to use
> STAGING_DIR_NATIVE in code as this is a known variable name and makes
> it easy to understand.
I'm going to disagree on that, I think this does make sense in the
context of the functions we're changing here.
On the other hand I'd love to simplify the whole *OFFLINE_ROOT mess but
that is for a different patch...
Cheers,
Richard
More information about the Openembedded-core
mailing list