[OE-core] [OE-Core][PATCH] packagroup-base: use virtual runtime instead of keymap

Paul Eggleton paul.eggleton at linux.intel.com
Tue Dec 11 09:30:53 UTC 2012


On Tuesday 11 December 2012 09:28:47 Paul Eggleton wrote:
> On Tuesday 11 December 2012 10:18:41 Martin Jansa wrote:
> > On Fri, Dec 07, 2012 at 04:44:15PM +0200, Ciprian Ciubotariu wrote:
> > > ---
> > > 
> > >  .../packagegroups/packagegroup-base.bb             |    2 +-
> > >  1 files changed, 1 insertions(+), 1 deletions(-)
> > > 
> > > diff --git a/meta/recipes-core/packagegroups/packagegroup-base.bb
> > > b/meta/recipes-core/packagegroups/packagegroup-base.bb index
> > > 347a7e1..3e75190 100644
> > > --- a/meta/recipes-core/packagegroups/packagegroup-base.bb
> > > +++ b/meta/recipes-core/packagegroups/packagegroup-base.bb
> > > @@ -141,7 +141,7 @@ RRECOMMENDS_packagegroup-machine-base =
> > > "${MACHINE_EXTRA_RRECOMMENDS}">
> > > 
> > >  SUMMARY_packagegroup-base-keyboard = "Keyboard support"
> > >  RDEPENDS_packagegroup-base-keyboard = "\
> > > 
> > > -    keymaps"
> > > +    ${VIRTUAL-RUNTIME_keymaps}"
> > 
> > you need to specify default value with weak assignment like
> > packagegroup-core-boot.bb does
> 
> Also, could you please include a commit message explaining why this is
> needed?

Ah, well; not so much why this is needed but explaining that this makes it 
consistent with packagegroup-core-boot.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre




More information about the Openembedded-core mailing list