[OE-core] gcc-4.7.inc wrong FILESPATH setting?

[Paul Eggleton]

On Monday 17 December 2012 14:51:59 Giuseppe Condorelli wrote:
> 2012/12/14 Robert P. J. Day <rpjday at crashcourse.ca>
> 
> > On Fri, 14 Dec 2012, Giuseppe Condorelli wrote:
> > > 2012/12/14 Robert P. J. Day <rpjday at crashcourse.ca>
> > > 
> > >       On Fri, 14 Dec 2012, Marko Katić wrote:
> > >       > On Fri, 2012-12-14 at 17:41 +0100, Giuseppe Condorelli wrote:
> > >       > > Hi All,
> > >       > > 
> > >       > > I've seen that, in the given .inc file, the FILESPATH is
> > 
> > statically
> > 
> > >       > > set to
> > >       > > 
> > >       > > FILESPATH = "${FILE_DIRNAME}/gcc-4.7"
> > >       > > 
> > >       > > This seems to avoid any FILESEXTRAPATHS_prepend usage on
> > 
> > append file.
> > 
> > >       > > I need to add further patches for gcc-4.7.2 in my own meta
> > 
> > layer but
> > 
> > >       > > if I set the FILESEXTRAPATHS_prepend as usual
> > >       > > nothing happens, sources are taken only from the directory set
> > 
> > by
> > 
> > >       > > FILESPATH.
> > >       > > Also I saw this setting was different in the past
> > >       > > 
> > >       > > FILESPATH = "${@base_set_filespath([ '${FILE_DIRNAME}/gcc-4.7'
> > 
> > ], d)}"
> > 
> > >   i'm fairly sure i posted on this recently.  base.bbclass
> > > 
> > > *explicitly* sets FILESPATH to a set of variations thusly:
> > > 
> > > FILESPATH = "${@base_set_filespath(["${FILE_DIRNAME}/${BP}",
> > 
> > "${FILE_DIRNAME}/${BPN}", "${FILE_DIRNAME}/files"], d)}"
> > 
> > > which works fine with the recipes in the underlying oe-core layer.
> > > 
> > >   however, when you use FILESEXTRAPATHS_prepend, you get additional
> > > 
> > > directories based on *only* the name you specify.  so if you do:
> > > 
> > > FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> > > 
> > > are you thinking you should also get all variations of "gcc-4.7"?
> > > because that's not what's going to happen.
> > > 
> > > I'm sorry, I've not catched your last sentence. I set (as in the
> > > past) the FILESEXTRAPATHS_prepend := "${THISDIR}/files:"
> > > also updating the SRC_URI inside the .bbappend file to use the
> > > sources available in the gcc directory available in my own layer.
> > > 
> >   did you also set THISDIR just above that?
> 
> No, I don't set it. Is it necessary now?

No, THISDIR is set automatically, you should not set it yourself.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre