[OE-core] [PATCH 2/3] dhcp: move dhcp leases files handling to postinst/postrm

Richard Purdie richard.purdie at linuxfoundation.org
Thu Feb 2 14:53:49 UTC 2012


On Thu, 2012-02-02 at 10:43 +0000, Phil Blundell wrote:
> On Wed, 2012-02-01 at 19:01 -0200, Otavio Salvador wrote:
> > On Wed, Feb 1, 2012 at 18:57, Phil Blundell <philb at gnu.org> wrote:
> >         On Wed, 2012-02-01 at 20:27 +0000, Otavio Salvador wrote:
> >         >  pkg_postinst_dhcp-server() {
> >         > +    install -d $D/${localstatedir}/lib/dhcp
> >         
> >         
> >         Is "install" guaranteed to be available on the target?  I
> >         would have
> >         thought "mkdir -p" would be better.
> > 
> > 
> > It worked on all images I tested. I have no strong opinions about it. 
> 
> I just checked a rootfs that I happened to have lying around and there
> was indeed no "install" binary in there.  Admittedly I always build with
> O_P_M=none so it isn't going to cause me any real problem, but
> presumably there might be other folks who have O_P_M on and still lack
> "install".  So I think it would be best to change this.

Agreed, mkdir is much more likely to be available than install on most
target machines.

Cheers,

Richard





More information about the Openembedded-core mailing list