[OE-core] [PATCH 1/1] netbase: make netbase recipe MACHINE specific for all targets

[Koen Kooi]

Op 3 feb. 2012, om 18:15 heeft Darren Hart het volgende geschreven:

> 
> 
> On 02/02/2012 10:59 AM, Joshua Lock wrote:
>> On 02/02/12 10:54, Koen Kooi wrote:
>>> 
>>> Op 2 feb. 2012, om 19:51 heeft Joshua Lock het volgende
>>> geschreven:
>>> 
>>>> Several BSP's are appending netbase to add MACHINE specific 
>>>> networking functionality. Rather than BSP creators having to
>>>> mark netbase MACHINE specific just default to PACKAGE_ARCH =
>>>> "${MACHINE_ARCH}" in netbase.
>>>> 
>>>> This shouldn't be a huge hit as netbase just copies files
>>>> around.
>>> 
>>> In the past OE would mark things machine specific if something in
>>> SRC_URI was fetched using overrides. So it this patches fixed
>>> netbase the 'old' mechanism is broken :(
>> 
>> This patch doesn't fix netbase, I just thought it would be simpler to
>> make this change than ensure all BSP's use appropriate OVERRIDEs in
>> their netbase bbappends - several I've seen don't.
>> 
> 
> Is there a consensus on whether or not this can go in? I need either
> this or the BSP layer fix for a new BSP. It seems to me that netbase is
> overridden enough for machine specific things (like the interface file)
> that Joshua's approach is the better fix.

It all depends on how much crap in BSPs you want to fix up in OE-core. Where are you going to draw the line?