[OE-core] [PATCH 1/3] cross.bbclass: add virtclass handler

[Otavio Salvador]

On Thu, Dec 8, 2011 at 20:09, Richard Purdie <
richard.purdie at linuxfoundation.org> wrote:

> > +            elif not dep.endswith("-cross"):
> > +                newdeps.append(dep + "-cross")
> > +            else:
> > +                newdeps.append(dep)
> > +        bb.data.setVar(varname, " ".join(newdeps), d)
>
> The logic here is just totally wrong. You can't ever hit the else case
> and the paths you do hit are nonsensical.


Fixed it.

> +    map_dependencies("DEPENDS", e.data)
> > +    for pkg in (e.data.getVar("PACKAGES", True).split() + [""]):
> > +        map_dependencies("RDEPENDS", e.data, pkg)
> > +        map_dependencies("RRECOMMENDS", e.data, pkg)
> > +        map_dependencies("RSUGGESTS", e.data, pkg)
> > +        map_dependencies("RPROVIDES", e.data, pkg)
> > +        map_dependencies("RREPLACES", e.data, pkg)
> > +
> > +    provides = e.data.getVar("PROVIDES", True)
> > +    for prov in provides.split():
> > +        if prov.find(pn) != -1:
> > +            continue
> > +        if not prov.endswith("-cross"):
> > +            provides = provides.replace(prov, prov + "-cross")
> > +    e.data.setVar("PROVIDES", provides)
>
> My suggestion is that you should just remove the DEPENDS and PROVIDES
> mapping code above and do it manually using the virtclass-cross override
> in the recipe. The above code can't have been doing much that is
> sensible anyway.
>

Right. I did it and will send an updated patch tomorrow after a from
scratch build.

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20120207/d05641de/attachment-0002.html>