[OE-core] [PATCH/RFC] xorg-lib: don't build libs unless requested by DISTRO_FEATURES

Paul Eggleton paul.eggleton at linux.intel.com
Fri Feb 10 12:19:50 UTC 2012


On Friday 10 February 2012 09:38:59 Koen Kooi wrote:
> I know you're just moving the error message around, but I would suggest
> changing it to "'x11' not in DISTRO_FEATURES".

You have to be careful with this, as it will pick up partial words e.g. 
assuming we had an "x11test" DISTRO_FEATURE then this would also be picked up 
by this statement; whereas oe.utils.contains() does a split to make it a list 
first and therefore does not have this issue. I'd suggest leaving it as-is, or 
if you really want to change it, do a split on the string first.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre




More information about the Openembedded-core mailing list