[OE-core] [PATCH 3/4] default-distrovars: Add empty weak definition for DISTRO variable

[Richard Purdie]

On Thu, 2012-02-23 at 19:33 -0800, Khem Raj wrote:
> Signed-off-by: Khem Raj <raj.khem at gmail.com>
> ---
>  meta/conf/distro/include/default-distrovars.inc |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/meta/conf/distro/include/default-distrovars.inc b/meta/conf/distro/include/default-distrovars.inc
> index 16b3108..dba204e 100644
> --- a/meta/conf/distro/include/default-distrovars.inc
> +++ b/meta/conf/distro/include/default-distrovars.inc
> @@ -41,6 +41,13 @@ NO32LIBS ??= "1"
>  
>  # Default to emitting logfiles if a build fails.
>  BBINCLUDELOGS ??= "yes"
> +
> +# dummy distro related variables
> +# they should be overridden by real distros
> +# these fallbacks only serve the purpose of
> +# oe-core standalone testability
> +
> +DISTRO ??= ""
>  SDK_VERSION ??= "oe-core.0"
>  DISTRO_VERSION ??= "oe-core.0"

Why do we need this? The commit message tells me what you're doing but
not why. I'm really getting frustrated with one line commit messages
with no details.

I don't think we should need this either, I'm not sure I like the
change. The whole idea was OE-Core could run "distroless".

Cheers,

Richard