[OE-core] [PATCH 0/5] LICENSE_FLAGS, a replacement for COMMERCIAL_LICENSE, v3

Tom Zanussi tom.zanussi at intel.com
Tue Jan 10 00:00:33 UTC 2012


On Mon, 2012-01-09 at 16:50 -0700, Chris Larson wrote:
> On Fri, Jan 6, 2012 at 7:34 PM,  <tom.zanussi at intel.com> wrote:
> > Possible values for LICENSE_FLAGS could be:
> > - Binary - provides some kind of binary with no source
> > - Patent - provides a potential infringing item, that some may not want
> > - Commercial - include recipes that may have commercial T&C
> > - Commercial_${PN} - commercial licenses specific to ${PN}
> > - License_${PN} - include a recipe that has a specific license
> >                 - maybe similar or different than Commercial_${PN}
> 
> It's a minor gripe really, but why the capitalization here? Other
> similar variables which define lists of words to control behavior
> (e.g. MACHINE_FEATURES, DISTRO_FEATURES, IMAGE_FEATURES, and others)
> have an all-lowercase convention. I think this should behave
> similarly, for consistency.

Right, the cover letter quotes the original e-mail that does have them
with caps.  The patches themselves use all-lowercase, though.

Thanks,

Tom





More information about the Openembedded-core mailing list