[OE-core] [CONSOLIDATED PULL 14/22] default-distrovars: Define DISTRO_FEATURES_LIBC for uclibc

Phil Blundell philb at gnu.org
Tue Jan 10 11:01:15 UTC 2012


On Mon, 2012-01-09 at 21:54 -0800, Saul Wold wrote:
> diff --git a/meta/conf/distro/include/default-distrovars.inc b/meta/conf/distro/include/default-distrovars.inc
> index e1594f3..0b515e5 100644
> --- a/meta/conf/distro/include/default-distrovars.inc
> +++ b/meta/conf/distro/include/default-distrovars.inc
> @@ -10,6 +10,8 @@ LIMIT_BUILT_LOCALES ?= "POSIX en_US en_GB"
>  ENABLE_BINARY_LOCALE_GENERATION ?= "1"
>  LOCALE_UTF8_ONLY ?= "0"
>  
> +DISTRO_FEATURES_LIBC_libc-uclibc ?= "ipv4 ipv6 largefile libc-posix-clang-wchar"
> +
>  DISTRO_FEATURES_LIBC ?= "ipv4 ipv6 libc-backtrace libc-big-macros libc-bsd libc-cxx-tests libc-catgets libc-charsets libc-crypt \
>  					libc-crypt-ufc libc-db-aliases libc-envz libc-fcvt libc-fmtmsg libc-fstab libc-ftraverse \
>  					libc-getlogin libc-idn libc-inet-anl libc-libm libc-libm-big libc-locales libc-locale-code \

This looks like a bad idea to me.  I think that override will cause
potentially surprising behaviour for folks who are trying to set
DISTRO_FEATURES_LIBC by hand.  And, as far as I can tell, this patch
won't make any functional difference since uclibc will just ignore the
features it doesn't understand.

p.






More information about the Openembedded-core mailing list