[OE-core] [CONSOLIDATED PULL 12/33] pkgconfig: Move pkg.m4 from -dev to package

Koen Kooi koen at dominion.thruhere.net
Thu Jan 19 11:04:21 UTC 2012


Op 19 jan. 2012, om 11:57 heeft Richard Purdie het volgende geschreven:

> On Thu, 2012-01-19 at 11:30 +0100, Koen Kooi wrote:
>> Op 19 jan. 2012, om 10:22 heeft Saul Wold het volgende geschreven:
>> 
>>> [YOCTO #1908]
>>> 
>>> Signed-off-by: Saul Wold <sgw at linux.intel.com>
>>> ---
>>> meta/recipes-devtools/pkgconfig/pkgconfig.inc     |    2 ++
>>> meta/recipes-devtools/pkgconfig/pkgconfig_0.25.bb |    2 +-
>>> 2 files changed, 3 insertions(+), 1 deletions(-)
>>> 
>>> diff --git a/meta/recipes-devtools/pkgconfig/pkgconfig.inc b/meta/recipes-devtools/pkgconfig/pkgconfig.inc
>>> index 641bfae..00c23d7 100644
>>> --- a/meta/recipes-devtools/pkgconfig/pkgconfig.inc
>>> +++ b/meta/recipes-devtools/pkgconfig/pkgconfig.inc
>>> @@ -31,3 +31,5 @@ do_configure_prepend () {
>>> }
>>> 
>>> BBCLASSEXTEND = "native nativesdk"
>>> +
>>> +FILES_${PN} += "${datadir}/aclocal/pkg.m4"
>> 
>> Why is this done exactly? M4 files do belong in the -dev package.
> 
> Think about the use cases for having pkgconfig installed. In the
> pkgconfig case, the -dev package isn't particularly useful. 

So put that in the commit message :)

> 
> You can argue this one both ways though...

I know, just being obnoxious about missing commit messages.



More information about the Openembedded-core mailing list